Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give props to contributors #1330

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Give props to contributors #1330

merged 1 commit into from
Jun 21, 2017

Conversation

jasmussen
Copy link
Contributor

This is a first stab at making a separate file containing contributors. It is a lot of manual work, but we can update it in bulk, and it's worth it to ensure people get virtual compliments for their hard work, even if that hard work might not be code specific.

This starts work at fixing #1223

CC: @ntwb, @karmatosed

This is a first stab at making a separate file containing contributors. It is a lot of manual work, but we can update it in bulk, and it's worth it to ensure people get virtual compliments for their hard work, even if that hard work might not be code specific.

This starts work at fixing #1223
@karmatosed
Copy link
Member

This seems a great first pass to me. ❤️

@jasmussen
Copy link
Contributor Author

Awesome! Merging.

@jasmussen jasmussen merged commit dcda8cb into master Jun 21, 2017
@jasmussen jasmussen deleted the add/contributors branch June 21, 2017 17:52
@nylen
Copy link
Member

nylen commented Jun 21, 2017

How did you generate this file? Let's automate it.

@jasmussen
Copy link
Contributor Author

How did you generate this file? Let's automate it.

Manual work. I started with the contributors listed in this repo, and then went through tickets where I knew people had contributed, like in the gutenberg testing tickets. This is admittedly somewhat prone to human error, but it's the only way I can think of that incluces people who didn't commit code, and isn't just a 1:1 inclusion of everyone who commented on tickets here.

@ntwb
Copy link
Member

ntwb commented Jun 22, 2017

"This list is manually curated to include valuable contributions by volunteers that do not include code, such as user testing, providing feedback, or mockups. Please edit this list to include new contributors as they come in. There is no particular order to this list. If you or someone else were omitted from this list, we assure you that was not intentional. Please let us know and we'll add you."

I think that do not include code should be removed and the file expanded to include code contributions also as when it comes time to add a "Props" commit to WordPress Core this list will be required, what also will be required are w.org usernames of the contributors, for example I'm @ntwb here on GitHub but @netweb on w.org, see #1350 as a first pass for this (A follow up to #1350 would be a good-first-issue for someone)

@nylen
Copy link
Member

nylen commented Jun 22, 2017

Let's automate it.

If we need it, generating a list of code contributors could be automated, and we could probably write something to help manage the list a bit too. This part I agree is a list that we need to add to manually:

Manual work. I started with the contributors listed in this repo, and then went through tickets where I knew people had contributed, like in the gutenberg testing tickets.

youknowriad pushed a commit that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants